add support for codebuild github PR refs pattern #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the delay on this. The change looks like it's not going to break existing usage. I haven't personally tested the new regex pattern though. Did you? I'm happy to merge this. I'll verify it doesn't break existing functionality, but I'll need your help verifying the new support for refs. Will ping you offline re: testing. Note, I checked the CodeBuild failure and it's unrelated to your change so I'm going ahead and merging even with the CodeBuild failure. I'll fix that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im from SageMaker Python SDK Team, we had to recently switch the codeebuild PR triggers to
SourceVersion = refs/pull/{pr-number}/head^{full-commit-SHA}) pattern.
To continue to support PR Comments via this fantastic tool, I wish to add support for this pattern.
More Info in: https://docs.aws.amazon.com/codebuild/latest/userguide/sample-source-version.html
Let me know if more details are needed.